-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ONYX-1604): track progressive onboarding tooltips #11657
Open
dariakoko
wants to merge
6
commits into
main
Choose a base branch
from
dariakoko/track-pregressive-onboarding-tooltips
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
src/app/Components/ProgressiveOnboarding/ProgressiveOnboardingAlertReminder.tsx
Outdated
Show resolved
Hide resolved
src/app/Components/ProgressiveOnboarding/ProgressiveOnboardingLongPressContextMenu.tsx
Outdated
Show resolved
Hide resolved
src/app/Components/ProgressiveOnboarding/ProgressiveOnboardingSaveArtwork.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves ONYX-1604
Description
Track progressive onboarding tooltips
Track then visible
Partially relevant slack thread with Xander: https://artsy.slack.com/archives/C05EQL4R5N0/p1741116191231399
tracking event:
> NOTE:
context_owner_type
is optional and will be missing for the'save-artwork'
onboarding tooltip only. Adding it will require some prop drilling, data said it's fine, but I'm open to other opinions.Some examples of the tracking event:
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.